From 5885dad9b66a100423e4b1f856bd10ae00792258 Mon Sep 17 00:00:00 2001
From: Matthias Andreas Benkard <code@mail.matthias.benkard.de>
Date: Thu, 3 Jul 2025 19:56:00 +0200
Subject: Hibernate: Specify explicit select clause in find calls.

Change-Id: I7308937c003aaa4cd4c16decd305154ebc146824
---
 src/main/java/eu/mulk/mulkcms2/benki/accesscontrol/Role.java |  2 +-
 src/main/java/eu/mulk/mulkcms2/benki/users/User.java         |  4 ++--
 src/main/java/eu/mulk/mulkcms2/benki/wiki/WikiResource.java  | 12 ++++++------
 3 files changed, 9 insertions(+), 9 deletions(-)

(limited to 'src')

diff --git a/src/main/java/eu/mulk/mulkcms2/benki/accesscontrol/Role.java b/src/main/java/eu/mulk/mulkcms2/benki/accesscontrol/Role.java
index 9b73084..9b45333 100644
--- a/src/main/java/eu/mulk/mulkcms2/benki/accesscontrol/Role.java
+++ b/src/main/java/eu/mulk/mulkcms2/benki/accesscontrol/Role.java
@@ -79,7 +79,7 @@ public class Role extends PanacheEntityBase {
   public Set<String> tags;
 
   public static Role getWorld() {
-    return find("from Role r join r.tags tag where tag = 'world'").singleResult();
+    return find("select r from Role r join r.tags tag where tag = 'world'").singleResult();
   }
 
   @Override
diff --git a/src/main/java/eu/mulk/mulkcms2/benki/users/User.java b/src/main/java/eu/mulk/mulkcms2/benki/users/User.java
index 9f2cd5c..b7ba545 100644
--- a/src/main/java/eu/mulk/mulkcms2/benki/users/User.java
+++ b/src/main/java/eu/mulk/mulkcms2/benki/users/User.java
@@ -148,13 +148,13 @@ public class User extends PanacheEntityBase {
   }
 
   public static User findByNickname(String nickname) {
-    return User.find("from BenkiUser u join u.nicknames n where ?1 = n", nickname).singleResult();
+    return User.find("select u from BenkiUser u join u.nicknames n where ?1 = n", nickname).singleResult();
   }
 
   public static User findByNicknameWithRoles(String nickname) {
     return User.find(
             ""
-                + "from BenkiUser u "
+                + "select u from BenkiUser u "
                 + "join u.nicknames n "
                 + "left join fetch u.effectiveRoles r "
                 + "left join fetch r.tags "
diff --git a/src/main/java/eu/mulk/mulkcms2/benki/wiki/WikiResource.java b/src/main/java/eu/mulk/mulkcms2/benki/wiki/WikiResource.java
index 42f7c63..22c7fa5 100644
--- a/src/main/java/eu/mulk/mulkcms2/benki/wiki/WikiResource.java
+++ b/src/main/java/eu/mulk/mulkcms2/benki/wiki/WikiResource.java
@@ -62,7 +62,7 @@ public class WikiResource {
 
     Optional<WikiPageRevision> maybePage =
         WikiPageRevision.find(
-                "from WikiPageRevision rev join fetch rev.author where rev.title = ?1",
+                "select rev from WikiPageRevision rev join fetch rev.author where rev.title = ?1",
                 Sort.by("date").descending(),
                 pageName)
             .firstResultOptional();
@@ -71,7 +71,7 @@ public class WikiResource {
     } else {
       var userName = identity.getPrincipal().getName();
       User user =
-          User.find("from BenkiUser u join u.nicknames n where ?1 = n", userName).singleResult();
+          User.find("select u from BenkiUser u join u.nicknames n where ?1 = n", userName).singleResult();
       page = new WikiPageRevision();
       page.content = "";
       page.title = pageName;
@@ -108,11 +108,11 @@ public class WikiResource {
 
     var userName = identity.getPrincipal().getName();
     User user =
-        User.find("from BenkiUser u join u.nicknames n where ?1 = n", userName).singleResult();
+        User.find("select u from BenkiUser u join u.nicknames n where ?1 = n", userName).singleResult();
 
     Optional<WikiPageRevision> maybeCurrentRevision =
         WikiPageRevision.find(
-                "from WikiPageRevision rev join fetch rev.author where rev.title = ?1",
+                "select rev from WikiPageRevision rev join fetch rev.author where rev.title = ?1",
                 Sort.by("date").descending(),
                 pageName)
             .firstResultOptional();
@@ -153,7 +153,7 @@ public class WikiResource {
   public TemplateInstance getPageRevisions(@PathParam("pageName") String pageName) {
     Optional<WikiPageRevision> maybePrimaryRevision =
         WikiPageRevision.find(
-                "from WikiPageRevision rev join fetch rev.author where rev.title = ?1",
+                "select rev from WikiPageRevision rev join fetch rev.author where rev.title = ?1",
                 Sort.by("date").descending(),
                 pageName)
             .firstResultOptional();
@@ -164,7 +164,7 @@ public class WikiResource {
 
     WikiPage page =
         WikiPageRevision.find(
-                "from WikiPage p"
+                "select p from WikiPage p"
                     + " join fetch p.revisions rev"
                     + " join fetch rev.author"
                     + " where p.id = ?1",
-- 
cgit v1.2.3